Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Namespaces #645

Merged
merged 4 commits into from
Jul 4, 2018
Merged

Simplify Namespaces #645

merged 4 commits into from
Jul 4, 2018

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

FIxes #620

Purely cosmetic with no functional changes.

  • All processing extensions now live under SixLabors.ImageSharp.Processing
  • All processors now live under SixLabors.ImageSharp.Processing.Processors.XXX

I've deliberately pushed things like IResampler implementations down into the Processors.XXX namespaces as I wan't to encourage use of the static KnownXXX instances.

I recommend separating out the ImageSharp and ImageSharp.Drawing documentation when we next publish an update to avoid clutter.

@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #645 into master will not change coverage.
The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files         893      893           
  Lines       38090    38090           
  Branches     2668     2668           
=======================================
  Hits        34023    34023           
  Misses       3269     3269           
  Partials      798      798
Impacted Files Coverage Δ
...rp.Tests/Processing/Convolution/DetectEdgesTest.cs 100% <ø> (ø) ⬆️
...rc/ImageSharp/Processing/GaussianBlurExtensions.cs 100% <ø> (ø)
...ng/Processors/Transforms/TransformProcessorBase.cs 100% <ø> (ø)
src/ImageSharp/Processing/SkewExtensions.cs 100% <ø> (ø)
src/ImageSharp/Processing/ResizeExtensions.cs 100% <ø> (ø)
src/ImageSharp.Drawing/Processing/Pen{TPixel}.cs 100% <ø> (ø)
...essing/Processors/Quantization/PaletteQuantizer.cs 100% <ø> (ø)
tests/ImageSharp.Tests/Drawing/DrawPathTests.cs 100% <ø> (ø) ⬆️
...ng/Processors/Convolution/RobertsCrossProcessor.cs 100% <ø> (ø)
...cessing/Processors/Transforms/Lanczos2Resampler.cs 100% <ø> (ø)
... and 279 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 741d5f3...0475a07. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with your decisions & can't spot anything wrong here.

@JimBobSquarePants JimBobSquarePants merged commit 1481b70 into master Jul 4, 2018
@JimBobSquarePants JimBobSquarePants deleted the js/simplify-namespaces branch July 4, 2018 04:23
antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants