Consume memory primitives from SixLabors.Core #665
Conversation
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
=========================================
- Coverage 89.67% 89.6% -0.07%
=========================================
Files 890 878 -12
Lines 37633 37229 -404
Branches 2472 2450 -22
=========================================
- Hits 33747 33359 -388
+ Misses 3182 3177 -5
+ Partials 704 693 -11
Continue to review full report at Codecov.
|
| @@ -120,7 +123,7 @@ public BufferArea<T> GetSubArea(int x, int y, int width, int height) | |||
| public BufferArea<T> GetSubArea(Rectangle rectangle) | |||
| { | |||
| ImageSharp.DebugGuard.MustBeLessThanOrEqualTo(rectangle.Width, this.Rectangle.Width, nameof(rectangle)); | |||
| DebugGuard.MustBeLessThanOrEqualTo(rectangle.Height, this.Rectangle.Height, nameof(rectangle)); | |||
| SixLabors.DebugGuard.MustBeLessThanOrEqualTo(rectangle.Height, this.Rectangle.Height, nameof(rectangle)); | |||
|
|
|||
| int x = this.Rectangle.X + rectangle.X; | |||
There was a problem hiding this comment.
We're mixing two DebugGuard methods now. We should ditch the ImageSharp one.
There was a problem hiding this comment.
Good catch! Having common internals is just too dangerous, we should probably drop [InternalsVisibleTo(...)] in SL.Core to avoid these issues.
There was a problem hiding this comment.
Yeah, though I was wondering whether we should just make them public and avoid duplication? They're useful and well tested.
There was a problem hiding this comment.
One can accidentally include and use such internals with R# (been there). I would rather share them through submodules in the future. For now it's just safer to hide them IMO.
There was a problem hiding this comment.
Hide them then. We can investigate private packages like they use for ASP Core in the future
Consume memory primitives from SixLabors.Core
Prerequisites
Description
SixLabors.Corepackage referenceSixLabors.CoreSixLabors.ImaSharp.MemorynamespaceFixes #619.