Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading requests 1532888210 #12

Closed
wants to merge 3 commits into from
Closed

Upgrading requests 1532888210 #12

wants to merge 3 commits into from

Conversation

mareliefi
Copy link

No description provided.

@mareliefi mareliefi changed the title Upgrading requests Upgrading requests 1532888210 Jun 25, 2024
@duncancb duncancb self-requested a review June 28, 2024 10:54
duncancb
duncancb reviewed Jun 28, 2024
View reviewed changes
Copy link

@duncancb duncancb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out this version of requests breaks docker.from_env.

See docker/docker-py#3256

Given that this is an external bug, I'm not sure that we want to upgrade yet...

@mareliefi
Copy link
Author

@duncancb this repo is already on requests 2.31.0 so I am closing this pull request:)

@mareliefi mareliefi closed this Jun 28, 2024
@HAASLEWER HAASLEWER deleted the maintenance-upgrade-requests branch July 9, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncancb duncancb duncancb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mareliefi @duncancb