feat: add way to inject custom prom-client instance #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
fastify-metrics
use internal, specific version ofprom-client
, it sometimes provide situations, where it need to share the promClient instance with external code. Often there much more other sources of metrics that need to be collection, other than fastify requests.Currently, it possible to get internally used
promClient
instance byfastifyApp.metrics.client
, but its not very convinient to use.This PR introduce a way to provide external
promClient
instance to use withfastify-metrics
.--
Additional advantage of this solution is to decrease risk of unintentional usage of 2 different
promClient
instances. It is possible when the project use different version ofprom-client
than thefastify-metrics
use internally.