fix: only start timers if they are enabled via configuration option #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 99.39% 98.82% -0.58%
==========================================
Files 2 2
Lines 165 170 +5
Branches 64 70 +6
==========================================
+ Hits 164 168 +4
Misses 1 1
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
## [10.4.1](v10.4.0...v10.4.1) (2023-11-28) ### 🛠 Fixes * only start timers if they are enabled via configuration option ([#97](#97)) ([6f0b8e2](6f0b8e2)) * rebuild ([a4fc811](a4fc811)) * rebuild ([82706e7](82706e7)) * remove old badges ([0730c2a](0730c2a)) ### 🧾 Other * **deps-dev:** bump @babel/traverse from 7.19.4 to 7.23.2 ([#91](#91)) ([b069b47](b069b47))
|
🎉 This PR is included in version 10.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey again,
My last PR seems like it might have a nasty memory leak, as the summary and histogram timers would get started on every request even if they have been disabled via the configuration option.
This PR fixes that issue by only initialising the timers if the relevant histogram/summary collection has been enabled.