added improved error handling.

package.json

@@ -42,7 +42,8 @@
     "trivialperms": "^2.0.0-beta.0",
     "ts-essentials": "^10.0.0",
     "zod": "^3.23.8",
-    "zod-express-middleware": "^1.4.0"
+    "zod-express": "^0.0.8",
+    "zod-validation-error": "^3.3.0"
   },
   "devDependencies": {
     "@ckpack/vue-color": "^1.3.0",
@@ -88,7 +89,7 @@
     "vue-router": "^4.1.6"
   },
   "overrides": {
-    "zod-express-middleware": {
+    "zod-express": {
       "express": "$express"
     }
   },

src/server/engines/validation/express.ts

@@ -0,0 +1,43 @@
+// ---------------------------------------------------------------------------------------------------------------------
+// Express Validation Tools
+// ---------------------------------------------------------------------------------------------------------------------
+
+import { Request, Response, NextFunction } from 'express';
+
+import { fromError } from 'zod-validation-error';
+
+// ---------------------------------------------------------------------------------------------------------------------
+
+export function validationErrorHandler(err : any, req : Request, res : Response, next : NextFunction) : void
+{
+    if(Array.isArray(err))
+    {
+        const errors = err.map((errObj) =>
+        {
+            return {
+                ...errObj,
+                errors: fromError(errObj.errors)
+            };
+        });
+
+        if(errors.length > 0)
+        {
+            const errorMsg = errors.map((errObj) =>
+            {
+                return `${ errObj.type }: ${ errObj.errors.toString() }`;
+            });
+
+            res.status(422).json({
+                message: `Request Validation Failed: ${ errorMsg.join('\n') }`,
+                errors
+            });
+
+            // Return to not call next
+            return;
+        }
+    }
+
+    next(err);
+}
+
+// ---------------------------------------------------------------------------------------------------------------------

src/server/routes/accounts.ts

@@ -3,20 +3,22 @@
 //----------------------------------------------------------------------------------------------------------------------
 
 import express from 'express';
-import { processRequest } from 'zod-express-middleware';
+import { processRequest } from 'zod-express';
 
 // Managers
 import * as accountMan from '../managers/account';
 import * as permsMan from '../managers/permissions';
 
 // Validation
 import * as AccountValidators from '../engines/validation/models/account';
+import { validationErrorHandler } from '../engines/validation/express';
 
 // Utils
 import { ensureAuthenticated, errorHandler } from './utils';
 
 // Logger
 import logging from '@strata-js/util-logging';
+
 const logger = logging.getLogger(module.filename);
 
 //----------------------------------------------------------------------------------------------------------------------
@@ -25,41 +27,62 @@ const router = express.Router();
 
 //----------------------------------------------------------------------------------------------------------------------
 
-router.get('/', processRequest({ query: AccountValidators.AccountFilter }), async(req, resp) =>
-{
-    resp.json((await accountMan.list(req.query)).map((accountObj) =>
-    {
-        const { permissions, settings, groups, ...restAccount } = accountObj;
-        return restAccount;
-    }));
-});
-
-router.get('/:accountID', processRequest({ params: AccountValidators.UpdateParams }), async(req, resp) =>
-{
-    const user = req.user;
-    const account = await accountMan.get(req.params.accountID);
-
-    const sameOrAdmin = user && (user.id === req.params.accountID || permsMan.hasPerm(user, `Accounts/canViewDetails`));
-
-    if(req.isAuthenticated() && sameOrAdmin)
+router.get(
+    '/',
+    processRequest({ query: AccountValidators.AccountFilter }, { passErrorToNext: true }),
+    async (req, resp) =>
     {
-        resp.json(account);
+        resp.json((await accountMan.list(req.query)).map((accountObj) =>
+        {
+            const {
+                permissions,
+                settings,
+                groups,
+                ...restAccount
+            } = accountObj;
+            return restAccount;
+        }));
     }
-    else
+);
+
+router.get(
+    '/:accountID',
+    processRequest({ params: AccountValidators.UpdateParams }, { passErrorToNext: true }),
+    async (req, resp) =>
     {
-        const { permissions, groups, settings, ...restAccount } = account;
-        resp.json(restAccount);
+        const user = req.user;
+        const account = await accountMan.get(req.params.accountID);
+
+        const sameOrAdmin = user && (user.id === req.params.accountID || permsMan.hasPerm(
+            user,
+            `Accounts/canViewDetails`
+        ));
+
+        if(req.isAuthenticated() && sameOrAdmin)
+        {
+            resp.json(account);
+        }
+        else
+        {
+            const {
+                permissions,
+                groups,
+                settings,
+                ...restAccount
+            } = account;
+            resp.json(restAccount);
+        }
     }
-});
+);
 
 router.patch(
     '/:accountID',
     ensureAuthenticated,
     processRequest({
         params: AccountValidators.UpdateParams,
         body: AccountValidators.Account.partial({ id: true })
-    }),
-    async(req, resp) =>
+    }, { passErrorToNext: true }),
+    async (req, resp) =>
     {
         // Update the account
         const newAccount = await accountMan.update(req.params.accountID, req.body);
@@ -71,6 +94,7 @@ router.patch(
 // Error Handling
 //----------------------------------------------------------------------------------------------------------------------
 
+router.use(validationErrorHandler);
 router.use(errorHandler(logger));
 
 //----------------------------------------------------------------------------------------------------------------------