APR-2890 Refactor Web and Internal API to use same Outer api client implementation #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevenKShah
requested review from
chrisfoster76,
MAli99 and
MarkFCain
as code owners
MarkFCain
previously approved these changes
Jan 4, 2022
DevenKShah
force-pushed
the
APR-2890-RefactorOuterApiClient
branch
from
3595b39
to
5e99fb9
Compare
MarkFCain
previously approved these changes
Jan 17, 2022
DevenKShah
force-pushed
the
APR-2890-RefactorOuterApiClient
branch
from
5e99fb9
to
6d4389c
Compare
MarkFCain
approved these changes
Jan 17, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing usage of charity commissions api forced to have two outer api clients. In this PR I have refactored the code so that there is only single simplified implementation of outer api client. This client is then used inside web controller and internal api service directly.
I have deleted CharityCommissionsController as this was only used in the admin service. When I looked inside admin service there was a client for this controller but no usage was found. I have created a separate PR to remove the client from admin service.
I have included minor code improvements that I came across.