APR-2909-PRG pattern in RoatpAppealsController without modelstate #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviudari01
requested review from
chrisfoster76,
DevenKShah,
MAli99 and
MarkFCain
as code owners
DevenKShah
requested changes
Jan 7, 2022
| @@ -140,7 +136,7 @@ public async Task<IActionResult> GroundsOfAppeal(GroundsOfAppealViewModel model) | |||
|
|
|||
| if (!ModelState.IsValid) | |||
| { | |||
| return RedirectToAction("GroundsOfAppeal", new { model.ApplicationId, model.AppealOnPolicyOrProcesses, model.AppealOnEvidenceSubmitted }); | |||
| return View("~/Views/Appeals/GroundsOfAppeal.cshtml", model); | |||
There was a problem hiding this comment.
You need to populate appeals file list in the model here, see the GET method. Refactor the model building logic in the GET method so it can be reused here.
There was a problem hiding this comment.
Refactored the code, but calling model build method is not required in the post as it is retaining the removed file
|
Kudos, SonarCloud Quality Gate passed! |
DevenKShah
approved these changes
Jan 13, 2022
DevenKShah
deleted the
APR-2909-PRG-Pattern-ModelState-RoatpAppealsController
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.