APR-2985-Gateway-checks-for-prefixed-charities-bug-fix #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of ServiceUnavailableException
raviudari01
requested review from
MarkFCain,
chrisfoster76,
MAli99 and
DevenKShah
as code owners
MarkFCain
reviewed
Mar 23, 2022
| @@ -110,7 +110,7 @@ private async Task LookupCharityCommissionDetails(ApplyGatewayDetails applyGatew | |||
| var message = | |||
| $"Unable to parse charity registration number from charity number in ukrlp: '{charityNumberFromUkrlp}'"; | |||
| _logger.LogError(message); | |||
There was a problem hiding this comment.
this is no longer an error, but an occasional, but expected condition. Can you change .LogError to .LogInformation
There was a problem hiding this comment.
Perhaps change the message as well. To something like Charity registration number cannot be parsed into a number, skipping getting details from charity commission for {charityNumber}
raviudari01
changed the title
MarkFCain
previously approved these changes
Mar 23, 2022
|
Kudos, SonarCloud Quality Gate passed! |
DevenKShah
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.