Add InventoryHolder -> Location converter (#6747)

* add holder -> location converter

* clean up despite failure
------

Co-authored-by: Moderocky <admin@moderocky.com>

src/main/java/ch/njol/skript/classes/data/DefaultConverters.java

@@ -151,6 +151,7 @@ public DefaultConverters() {}
 				return (InventoryHolder) s;
 			return null;
 		}, Converter.NO_RIGHT_CHAINING | Commands.CONVERTER_NO_COMMAND_ARGUMENTS);
+
 		Converters.registerConverter(InventoryHolder.class, Block.class, holder -> {
 			if (holder instanceof BlockState)
 				return new BlockInventoryHolder((BlockState) holder);
@@ -165,7 +166,19 @@ public DefaultConverters() {}
 				return (Entity) holder;
 			return null;
 		}, Converter.NO_CHAINING);
-
+
+		// InventoryHolder - Location
+		// since the individual ones can't be trusted to chain.
+		Converters.registerConverter(InventoryHolder.class, Location.class, holder -> {
+			if (holder instanceof Entity)
+				return ((Entity) holder).getLocation();
+			if (holder instanceof Block)
+				return ((Block) holder).getLocation();
+			if (holder instanceof BlockState)
+				return BlockUtils.getLocation(((BlockState) holder).getBlock());
+			return null;
+		});
+
 		// Enchantment - EnchantmentType
 		Converters.registerConverter(Enchantment.class, EnchantmentType.class, e -> new EnchantmentType(e, -1));
 

src/test/skript/tests/regressions/6424-inventory-holder-location.sk

@@ -0,0 +1,16 @@
+test "inventory holder location":
+	set {_b} to the block at spawn of world "world"
+	set {_prev} to type of block at {_b}
+	broadcast {_prev}
+
+	set block at {_b} to a chest
+	set {_inv} to inventory of {_b}
+	set {_holder} to holder of {_inv}
+
+	set {_a-loc} to location of {_holder}
+	set {_b-loc} to location of {_b}
+
+	# clean up first in case assert fails
+	set block at {_b} to {_prev}
+
+	assert {_a-loc} is {_b-loc} with "holder location differs from block location"