Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of example scripts #2252

Closed
bensku opened this issue Jul 15, 2019 · 8 comments
Closed

State of example scripts #2252

bensku opened this issue Jul 15, 2019 · 8 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@bensku
Copy link
Member

bensku commented Jul 15, 2019

Current example scripts are outdated. They're also often not terribly good examples, which is probably quite confusing for newbies. And, finally, they not all of them work. This needs to change.

I have three potential fixes which I would like feedback on.

Just remove them

Remove example scripts from Skript. Point users to online resources for usable scripts and tutorials.

Fix current examples

Fix current example scripts that do not work. Check all of them for style issues and do changes as needed. Possibly introduce a few new examples for new Skript features.

Rework example scripts

Throw most, if not all, of current examples to rubbish bin. Create new ones, and this time, actually design them to teach new users. Add both very simple (/hat) and somewhat more complex (a simple chat system) examples.

Don't dump example scripts in scripts directory on first load, but instead allow doing that with commands. Possibly allow running unmodified example scripts from Skript jar directly.

I'm honestly not sure which option is the best. First one would require the least amount of effort, while the third option would definitely require a lot of outside contributions.

@bensku bensku added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jul 15, 2019
@APickledWalrus
Copy link
Member

I’d say that reworking and fixing them is probably the best idea. I remember looking at the scripts when I first started, so they can come in handy for beginners.

@Blueyescat
Copy link
Contributor

Blueyescat commented Jul 16, 2019

What about a GitHub repository for official example scripts (not for dumping into the scripts folder)? It would be easier to manage the scripts and its README would contain a "how to load" info, this would also teach the users how to load a ready to use script. But all PRs should be reviewed properly in that repository, it should not be a place to share big scripts, scripts shouldn't contain author/contributors info.

Thus a new Skript release wouldn't need to update the scripts, the scripts folder wouldn't be ugly on first load. But there should be a file that leads the user to the examples repository.

I don't really think it is worth to work on a command system right now.


Edit: I may change my mind lol, it might be better to just keep them in the scripts folder, just update them.

@jaylawl
Copy link
Contributor

jaylawl commented Jul 16, 2019

I remember when i first downloaded Skript, that i was very grateful for the provided example scripts and they instantly taught me how stuff works on a basic level. I think they should stay in

@bensku
Copy link
Member Author

bensku commented Jul 16, 2019

@Blueyescat Separate git repository would be good in any case. It can be included in jar if needed by using git submodules.

@Matocolotoe
Copy link
Contributor

I think they should work the same as the new aliases, on a seperate repository and able not to load by default.

@gmalone
Copy link

gmalone commented Aug 26, 2019

Who are the key players in the world of Skript that are available, willing and can get a cleanup reorganization underway resulting in an authoritative Sk-code reference repository?

@gmalone
Copy link

gmalone commented Aug 27, 2019

As a relatively new user of Skript -- but a highly experienced coder in many langs over decades -- I must make this comment about Skript and its documentation. Skript may be mostly fine as it is, but the docs are far too sparse, thus limiting the long term potential of Skript, and in the 'plugins' world leading to sometimes deserved mockery, though often just ignorant mockery. It doesn't have to be that way.

All categories of Skript documentation desperately need more working examples, as this submitted issue asserts. Case in point -- how to build and implement custom commands and their arguments. The several existing documentation sites are poorly supported with solid examples -- limiting information to bare syntax and rare examples.

The core problem immediately arising with Skript is the confusing variety of ways things can be expressed. Though the intent must've been to make Skript a "natural language" device, it only makes things more complicated and unclear about what any given correct syntax might be. Thus, the lack of a central repository of syntax AND usage examples is a major hurdle for new users.

Here in late 2019 Minecraft is beginning to experience a resurgence after a drought that began after the sale to Microsoft and lost focus for the game's future. But Microsoft/Mojang are starting to get their Minecraft game on, and the world is reacting, including developers. My recommendation is that whoever has the capacity to drive a new wave of cleanup and clarification of Skript should do so soon and with purpose.

@bensku
Copy link
Member Author

bensku commented Aug 31, 2019

I agree with @gmalone; both Skript and the documentation really need improvements. Unfortunately, I don't think we can address all major issues anytime soon. To put it simply, I (and, as far as I know, other Skript developers) don't have enough time.

Skript, unfortunately, has a huge learning cliff for people who want to dive into its Java code. This is mostly due to missing documentation, and in my opinion, is slowly improving.

@Olyno Olyno mentioned this issue Oct 3, 2019
8 tasks
Olyno pushed a commit to Olyno/Skript that referenced this issue Oct 13, 2019
ShaneBeee pushed a commit that referenced this issue Mar 7, 2020
* Ref #2252: update old scripts examples
* Fix english grammar in vanilla gui example script
* Reimplement simple motd example
* Reimplement and fix furnace automatisation example script
* Make more understandable and flexible vanilla gui script example
* Fix english grammar in example scripts
* Added precisions about blacklisted items in item command example script
* Fix unecessary permission and permissions name in example scripts
* Improve kill counter example script
@Whimsyturtle Whimsyturtle added the priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). label Jul 10, 2020
@AyhamAl-Ali AyhamAl-Ali added the PR available Issues which have a yet-to-be merged PR resolving it label Mar 6, 2022
@TheLimeGlass TheLimeGlass added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

9 participants