Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

damage-effect doesn't show damage #2760

Closed
Thibaut040 opened this issue Jan 13, 2020 · 2 comments
Closed

damage-effect doesn't show damage #2760

Thibaut040 opened this issue Jan 13, 2020 · 2 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@Thibaut040
Copy link

Description

When you use "damage entity by x hearts", you can't see the entity taking damage.

Steps to Reproduce

  1. Load this script:
on rightclick:
	damage event-entity by 2 hearts
  1. Click on a mob; you'll see nothing. If you repeat clicking, the mob will die.

Expected Behavior

In 2.4.1, you saw the mob was taking damage. So there's a little bug. :)

Errors / Screenshots

N/A

Server Information

  • Server version/platform: Paper 1.15.1 build 43
  • Skript version: 2.5; it does work on 2.4.1

Additional Context

I already opened an issue 'removing x from health', which is closed, and I understand why... and I've been told I should open another if this doesn't work either. So, here it is
@ShaneBeee
Copy link
Contributor

ShaneBeee commented Jan 13, 2020 •
edited
Loading

This is due to WealthyTurtle changing the damage method in HealthUtils.
The change he applied was setting the health of the entity rather than damaging the entity. Due to that, the entity no longer takes damage.
This change will need to be reverted.

@ShaneBeee ShaneBeee added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Jan 13, 2020
@ShaneBeee ShaneBeee mentioned this issue Jan 13, 2020
Merged
bensku pushed a commit that referenced this issue Feb 3, 2020
@ShaneBeee
Fix damage effect not showing damage (#2760)
cd2abe2 
* HealthUtils - fix an issue with entity not taking damage when using damage effect

* HealthUtils - fix CRLF

* EffHealth test - remove 1 line of damage
- This is a spigot/MC issue (not a skript issue), damaging an entity in quick succession to many times causes the entity to not take all damage
@bensku bensku added the completed The issue has been fully resolved and the change will be in the next Skript update. label Feb 3, 2020
@ShaneBeee
Copy link
Contributor

Fixed in 2.5-alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bensku @ShaneBeee @Thibaut040