Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sending without the need of strings #3164

Closed
Runakai1 opened this issue Jul 18, 2020 · 5 comments
Closed

sending without the need of strings #3164

Runakai1 opened this issue Jul 18, 2020 · 5 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Milestone

Comments

@Runakai1
Copy link

It would be a very handy feature if you could just insert variables in the send effect. So you don't have to put "%%" around it and would just convert it into a string by itself. That would make debugging a bit less frustrating

@ShaneBeee
Copy link
Contributor

This could be fairly simple to add, and I could see this being useful, basically

send {_myThing}.toString()

@ShaneBeee ShaneBeee added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Jul 18, 2020
@Runakai1
Copy link
Author

This could be fairly simple to add, and I could see this being useful, basically

send {_myThing}.toString()

Exactly what I did with my mirror snippet. I'm looking forward seeing it being in skript 🍡

@FranKusmiruk FranKusmiruk added this to the 2.6 milestone Jul 18, 2020
@Pikachu920
Copy link
Member

@Runakai1 in case you want to the "true" skript string representation you can do it like so:

send Classes.toString({_myThing})

where Classes is ch.njol.skript.registrations.Classes

@FranKusmiruk
Copy link
Member

I think same should then be done for function arguments, so you can include number in a string argument

I am not sure I am understanding the feature being requested here, how would you implement this in functions?

@chatasma
Copy link
Contributor

chatasma commented Jul 22, 2020

I think same should then be done for function arguments, so you can include number in a string argument

I am not sure I am understanding the feature being requested here, how would you implement this in functions?

I believe they mean that function parameters that accept strings should implicitly convert respective parameters that are not of the string type, to a string

@TPGamesNL TPGamesNL added PR available Issues which have a yet-to-be merged PR resolving it completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

6 participants