Make message and broadcast effects accept objects #3951
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes
EffMessage
andEffBroadcast
accept objects to broadcast, instead of just strings.Also makes it so the effects don't call any of the expressions getters multiple times (which is what the ugly code at the start of the second loop in
EffMessage#execute
is for):will now only call
doStuff
once, used to be twice.Target Minecraft Versions: any
Requirements: none
Related Issues: #3164