Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make newline work in lore and tellraw #3544

Closed
AyhamAl-Ali opened this issue Nov 14, 2020 · 8 comments
Closed

Make newline work in lore and tellraw #3544

AyhamAl-Ali opened this issue Nov 14, 2020 · 8 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update.

Comments

@AyhamAl-Ali
Copy link
Member

I always loved SkQuery's new line feature, it just works everywhere with no problem at all.

I was happy when skript added their own but after trying it I found out that it doesn't work with /tellraw command nor item lore.

As for item lore there will be someone that will say use with lore "" and "" but that is just not functional nor nice, it is not just about few more chars many people just like the simplicity of || or %nl% when making new lines in lore.

and it is even better to have multiple ways to make new lines in item lore
I hope you got my point.

For item lore the second line and all lines below just doesn't appear and for tellraw it says Expected whitespace to end one argument, but found trailing data

Thank you.

@AyhamAl-Ali AyhamAl-Ali changed the title Make newline work in lore and nbt Make newline work in lore and tellraw Nov 14, 2020
@ShaneBeee
Copy link
Contributor

ShaneBeee commented Nov 14, 2020

As for the lore, I'm not entirely sure what you are talking about.

I have seen many people use the new line expression in lore and its worked.
I just tested it:
Screen Shot 2020-11-14 at 3 37 32 PM
Appears to work as expected.

As for the tellraw, Im not sure how that would even work, does tell raw support line separators?

@ShaneBeee
Copy link
Contributor

Did another test, apparently you can just use \n in tell raw

Screen Shot 2020-11-14 at 3 43 55 PM

@AyhamAl-Ali
Copy link
Member Author

As for me the lore doesn't work
image

as for tellraw I'm using the known script json.sk, I used to use %nl% in tooltips and it works but now it doesn't anymore, I had to edit json.sk to use \n

@AyhamAl-Ali
Copy link
Member Author

AyhamAl-Ali commented Nov 14, 2020

Apparently nl works with set lore but with lore doesn't
image

@AyhamAl-Ali
Copy link
Member Author

as for the json this is some more details

Using json("PLAYER", "test||ttp:Line 1%nl%Line 2")
This will throw an error in console saying the following
image

@ShaneBeee
Copy link
Contributor

If thats the case, I recommend just using lore lists.
Im not sure why people say commas and quotes are longer
", " is exactly the same amount of characters as %nl% ... 4!

That said, I don't see this being "fixed" as it's not broken, and Skript added lore lists for a reason.
It seems counter productive to move backwards.

Im going to mark this as "dev needed" to see what the rest of the team thinks, because in my opinion, this is a non-issue and something I personally would not spend any time on.

@AyhamAl-Ali
Copy link
Member Author

As for item lore there will be someone that will say use with lore "" and "" but that is just not functional nor nice, it is not just about few more chars many people just like the simplicity of || or %nl% when making new lines in lore.

I pointed that out before because this was suggested before long time ago and same answer were given,

Not sure about other users but for me I just don't like to keep adding more quotes for new lines, I like to stay in one double quotes and just use a simple separator like || or %nl% that is what I meant, I would also like to hear others opinion of course.

as for the bug part, i think there is a bug in with lore as it just doesn't support newline expression which by default it should because it is related.

@MrScopes
Copy link
Contributor

as far as lores go, it's meant for you to use lore as a list, ie:

with lore "hi", "hello" and "hi man"

instead of

with lore "hi%nl%hello%nl%hi man"

@ShaneBeee ShaneBeee added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update.
Projects
None yet
Development

No branches or pull requests

3 participants