Apply new line (%nr%) in item lore correctly
#3636
Merged
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukukotani
changed the title
%nr%) in item lore correctly
Pikachu920
requested changes
Dec 14, 2020
| @@ -62,10 +64,13 @@ public boolean init(Expression<?>[] exprs, int matchedPattern, Kleenean kleenean | |||
|
|
|||
| @Override | |||
| protected ItemType[] get(Event e, ItemType[] source) { | |||
| String[] lore = this.lore.getArray(e); | |||
| List<String> lore = Arrays.stream(this.lore.getArray(e)) | |||
There was a problem hiding this comment.
stream looks nice, but you should be able to replace the Arrays#stream call with this.lore.stream(e)
There was a problem hiding this comment.
Thanks. I didn't know about such a nice method!
Pikachu920
previously approved these changes
Dec 15, 2020
ShaneBeee
previously approved these changes
Dec 15, 2020
ShaneBeee
dismissed stale reviews from Pikachu920 and themself
The base branch was changed.
ShaneBeee
approved these changes
Dec 15, 2020
ShaneBeee
added
2.5
bug
APickledWalrus
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply new line (
%nr%) in item lore. It seems that #2505 forgot this.e.g.
1 of stone with lore "first line%nl%second line"The test case describes the behavior well.
Target Minecraft Versions: any
Requirements: none
Related Issues: #3544.