Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCE with ExprXOf with invalid types #3814

Closed
TPGamesNL opened this issue Mar 13, 2021 · 0 comments
Closed

CCE with ExprXOf with invalid types #3814

TPGamesNL opened this issue Mar 13, 2021 · 0 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@TPGamesNL
Copy link
Member

TPGamesNL commented Mar 13, 2021 •
edited
Loading

Description

I got a ClassCastException

Steps to Reproduce

run

set {_x} to 8
set {_y} to 5 of {_x}

{_x} can be any type, as long as it's not an item or entity type

Expected Behavior

No exception, {_y} shouldn't be set

Errors / Screenshots

https://pastebin.com/vd7cNEZq

Server Information

  • Server version/platform: git-Paper-529 (MC: 1.16.5)
  • Skript version: 2.5.3

Additional Context

ExprXOf#getExpr's return type was set to Object due to its implementation of getConvertedExpression (the expression was converted to Object). The conversion was implemented in 4088ce1

Related / duplicate: #3231
@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Mar 13, 2021
@TPGamesNL TPGamesNL mentioned this issue Mar 22, 2021
Closed
This was referenced Jun 12, 2021
Closed
Closed
@TPGamesNL TPGamesNL added priority: low Issues that are not harmful to the experience but are related to useful changes or additions. and removed priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Jun 21, 2021
@TPGamesNL TPGamesNL mentioned this issue Aug 9, 2021
Merged
@TPGamesNL TPGamesNL added PR available Issues which have a yet-to-be merged PR resolving it completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@APickledWalrus @TPGamesNL