Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExprXOf CCE #4261

Merged
merged 5 commits into from
Aug 16, 2021
Merged

Fix ExprXOf CCE #4261

merged 5 commits into from
Aug 16, 2021

Conversation

TPGamesNL
Copy link
Member

Description

The code removed (getConvertedExpression) was originally meant to fix #1747, see commit. However, removing this code no longer produces this issue, so I presume the main cause was fixed at some point.


Target Minecraft Versions: any
Requirements: none
Related Issues: #3814

@TPGamesNL TPGamesNL added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Aug 9, 2021
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little things. Other than that, looks good to me as long as this all still works error free 😎😎

src/main/java/ch/njol/skript/expressions/ExprXOf.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprXOf.java Outdated Show resolved Hide resolved
@TPGamesNL TPGamesNL merged commit bcebdef into SkriptLang:master Aug 16, 2021
@TPGamesNL TPGamesNL deleted the fix/exprxof-CCE branch August 16, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Returning Items from a Function
2 participants