Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on break of oak_log does work. #3900

Closed
HelParadox opened this issue Apr 13, 2021 · 5 comments
Closed

on break of oak_log does work. #3900

HelParadox opened this issue Apr 13, 2021 · 5 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@HelParadox
Copy link

I was just trying to write a simple skript with this expression and it was give me an error.

I put in the code "on break of oak_log:"

It should have detected if the oak log was broken and run some other code

2021-04-12_17 37 54

Server version: git-Paper-"b89788a" (MC: 1.16.5)
Skript Version: 2.5.3-MH

@MinecollYT
Copy link

Use on break of oak log:

@TPGamesNL TPGamesNL added the waiting for reply The report needs a response from the reporter to determine course of action. label Apr 13, 2021
@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Apr 25, 2021

Can confirm on vanilla Skript 2.5.3 and MC 1.16.5

oak_log = Error
oak log = Working

EDIT:
Note sure if this is intended or not but in older released using underscores in aliases used to work

Not just oak_log other items as well, not sure if all

@TPGamesNL
Copy link
Member

TPGamesNL commented Apr 27, 2021

oak log is a normal item type, but oak_log is a block data, which cannot be used everywhere (e.g. oak_log with lore "abc" errors too).
You should stick to using the aliases instead of textual IDs for now, although having more support for block data is a suggestion.

@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. and removed waiting for reply The report needs a response from the reporter to determine course of action. labels Apr 27, 2021
@APickledWalrus
Copy link
Member

I believed this was added in #4033 which has been merged (and is in beta builds). I am going to close this issue since it should have been resolved.

@APickledWalrus APickledWalrus added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

6 participants
@AyhamAl-Ali @APickledWalrus @TPGamesNL @MinecollYT @HelParadox and others