Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/block event block data #4033

Merged
merged 4 commits into from
Jun 17, 2021
Merged

Feature/block event block data #4033

merged 4 commits into from
Jun 17, 2021

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to add support for BlockData in block events.

NOTE:

  • I created a second class EvtBlockLegacy, this was to keep the class clean without 100+ checks throughout the code to see if BlockData exists/is supported.
  • When we finally drop legacy support, we can simply delete the EvtBlockLegacy class, and not have to worry about any code cleanup.

Target Minecraft Versions: 1.13+
Requirements: none
Related Issues: none

@ShaneBeee ShaneBeee added enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.6 labels May 26, 2021
APickledWalrus
APickledWalrus requested changes Jun 9, 2021
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major ;D looks pretty good overall

src/main/java/ch/njol/skript/events/EvtBlockLegacy.java Show resolved Hide resolved
src/main/java/ch/njol/skript/events/EvtBlock.java Show resolved Hide resolved
APickledWalrus
APickledWalrus approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
With those out of the way, I think you are good to go!

@ShaneBeee ShaneBeee merged commit 99d9450 into SkriptLang:master Jun 17, 2021
@ShaneBeee ShaneBeee deleted the feature/block-event-block-data branch June 17, 2021 05:43
@APickledWalrus APickledWalrus mentioned this pull request Jul 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APickledWalrus APickledWalrus APickledWalrus approved these changes

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaneBeee @APickledWalrus