Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water is not a block in 1.19.4 #5946

Closed
1 task done
Envqu opened this issue Aug 27, 2023 · 10 comments
Closed
1 task done

Water is not a block in 1.19.4 #5946

Envqu opened this issue Aug 27, 2023 · 10 comments
Labels
addon-related An issue that is related to an addon and not Skript. invalid Not a Skript issue, already implemented, does not apply, etc.

Comments

@Envqu
Copy link

Envqu commented Aug 27, 2023

Skript/Server Version

[23:21:26 INFO]: [Skript] Server Version: git-Purpur-1967 (MC: 1.19.4)
[23:21:26 INFO]: [Skript] Skript Version: 2.7.0-beta3 (skriptlang-github)
[23:21:26 INFO]: [Skript] Installed Skript Addons: 
[23:21:26 INFO]: [Skript]  - skript-placeholders v1.5.2 (https://github.com/APickledWalrus/skript-placeholders)
[23:21:26 INFO]: [Skript]  - skript-db v1.3.9
[23:21:26 INFO]: [Skript]  - SkQuery v4.1.9
[23:21:26 INFO]: [Skript]  - SkBee v2.8.4 (https://github.com/ShaneBeee/SkBee)
[23:21:26 INFO]: [Skript] Installed dependencies: 
[23:21:26 INFO]: [Skript]  - Vault v1.7.3-b131
[23:21:26 INFO]: [Skript]  - WorldGuard v7.0.7+216b061

Bug Description

Water is not a thing in 1.19.4.
Instead of "water" you have to type "minecraft:water"

Expected Behavior

"water" should work as always.

Steps to Reproduce

Not works:

loop all blocks in radius 2 of event-location:
	if loop-block is water:
		broadcast "X"

There's no loop that matches 'loop-block is water'

Works:

loop all blocks in radius 2 of event-location:
	if loop-block is minecraft:water:
		broadcast "X"

Not works:

block under {_loc} is lava or water:
	broadcast "X"

Can't compare a block with an object

Works:

block under {_loc} is lava or minecraft:water:
	broadcast "X"

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@sovdeeth
Copy link
Member

sovdeeth commented Aug 27, 2023

Already fixed in #5503, cannot replicate either error in 2.7.0-beta3, 1.19.4 or 1.20.1

@sovdeeth sovdeeth added the invalid Not a Skript issue, already implemented, does not apply, etc. label Aug 27, 2023
@sovdeeth
Copy link
Member

Oops didn't mean to close

@sovdeeth sovdeeth reopened this Aug 27, 2023
@sovdeeth sovdeeth added investigating The core developers are currently investigating this issue. Usually used for complex cases. cannot reproduce An issue that cannot be replicated. and removed invalid Not a Skript issue, already implemented, does not apply, etc. labels Aug 27, 2023
@Fusezion
Copy link
Contributor

This can be closed as the issue was caused by type.arts is what the error should say.

Additionally any old issues for this would of been closed. This was fixed in at least 2.7beta2 maybe beta1

@sovdeeth
Copy link
Member

sovdeeth commented Aug 27, 2023

This can be closed as the issue was caused by type.arts is what the error should say.

Additionally any old issues for this would of been closed. This was fixed in at least 2.7beta2 maybe beta1

The submitter apparently is on skript 2.7.0-beta3, indicating it didn't get fixed.

If no one else can replicate, it can be closed.

@Envqu
Copy link
Author

Envqu commented Aug 27, 2023

First example is fixed. Before I was using beta2.
But second still occurs on beta3

@sovdeeth
Copy link
Member

First example is fixed. Before I was using beta2. But second still occurs on beta3

Have you tested without addons?

@Envqu
Copy link
Author

Envqu commented Aug 27, 2023

Yes. This is my example and its not works

options:
	world: world
	x-max: 800
	x-min: -800
	z-max: 800
	z-min: -800

command /test:
	trigger:
		set {_loc} to location at random integer between {@x-min} and {@x-max}, 260, random integer between {@z-min} and {@z-max} in "{@world}"
		while "%region at {_loc}%" is not "<none>":
			set {_loc} to location at random integer between {@x-min} and {@x-max}, 260, random integer between {@z-min} and {@z-max} in "{@world}"
		while block under {_loc} is air or lava:
			remove 1 from y-coords of {_loc}
			block under {_loc} is lava or water:
				set {_loc} to location at random integer between {@x-min} and {@x-max}, 260, random integer between {@z-min} and {@z-max} in "{@world}"
				while "%region at {_loc}%" is not "<none>":
					set {_loc} to location at random integer between {@x-min} and {@x-max}, 260, random integer between {@z-min} and {@z-max} in "{@world}"
		if block under {_loc} is snow or short grass:
			remove 1 from y-coords of {_loc}
		set block at {_loc} to stone
[00:03:22 INFO]: Line 26: (test.sk)
[00:03:22 INFO]:     Can't compare a block with an object
[00:03:22 INFO]:     Line: block under {_loc} is lava or water:

@sovdeeth
Copy link
Member

sovdeeth commented Aug 27, 2023

Yes. This is my example and its not works

options:
	world: world
	x-max: 800
	x-min: -800
	z-max: 800
	z-min: -800

command /test:
	trigger:
		set {_loc} to location at random integer between {@x-min} and {@x-max}, 260, random integer between {@z-min} and {@z-max} in "{@world}"
		while "%region at {_loc}%" is not "<none>":
			set {_loc} to location at random integer between {@x-min} and {@x-max}, 260, random integer between {@z-min} and {@z-max} in "{@world}"
		while block under {_loc} is air or lava:
			remove 1 from y-coords of {_loc}
			block under {_loc} is lava or water:
				set {_loc} to location at random integer between {@x-min} and {@x-max}, 260, random integer between {@z-min} and {@z-max} in "{@world}"
				while "%region at {_loc}%" is not "<none>":
					set {_loc} to location at random integer between {@x-min} and {@x-max}, 260, random integer between {@z-min} and {@z-max} in "{@world}"
		if block under {_loc} is snow or short grass:
			remove 1 from y-coords of {_loc}
		set block at {_loc} to stone

I have no issues with it on 1.19.4 and 2.7.0-beta3. Can you send a screenshot of the error and your /sk info together? Without addons!

@Envqu
Copy link
Author

Envqu commented Aug 27, 2023

Okay, no errors without addons. Error is caused by SkQuery.
Sorry for bothering

@sovdeeth
Copy link
Member

Good to hear, thanks.

@sovdeeth sovdeeth closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2023
@sovdeeth sovdeeth added invalid Not a Skript issue, already implemented, does not apply, etc. addon-related An issue that is related to an addon and not Skript. and removed investigating The core developers are currently investigating this issue. Usually used for complex cases. cannot reproduce An issue that cannot be replicated. labels Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon-related An issue that is related to an addon and not Skript. invalid Not a Skript issue, already implemented, does not apply, etc.
Projects
None yet
Development

No branches or pull requests

3 participants