Fix the legendary compare issue with two same literals #5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
the
bug
Closed
1 task
TheLimeGlass
added
the
priority: medium
Moderocky
reviewed
Apr 8, 2023
Yes |
Moderocky
approved these changes
Apr 14, 2023
Moderocky
reviewed
Apr 14, 2023
Co-authored-by: Kenzie <admin@moderocky.com>
|
Also, tests are failing |
AyhamAl-Ali
requested changes
Apr 23, 2023
src/test/java/org/skriptlang/skript/test/tests/regression/HangingEntity_4871.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/test/tests/regression/HangingEntity_4871.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
APickledWalrus
requested changes
May 25, 2023
UnderscoreTud
approved these changes
May 26, 2023
Co-authored-by: _tud <mmbakkar06@gmail.com>
1 task
APickledWalrus
approved these changes
May 30, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the legendary compare issue with two same literals. Example: Skript would set
fireas visual effect, and then if you went to compare it against a block it would error. Skript should be assumingfireis an itemtype and compare against it. More details at #5497I also added file context to the EffAssert because I had many tests fail during testing and needed to know which files they belong to.
I also added event-block and event-location to the test event so that it can match the JUnit values.
Target Minecraft Versions: any
Requirements: none
Related Issues: #2711, #4773, #5497, #5557 and #5675 there are probably more I couldn't find.
duplicates: #4769, #4774, #4779, #4809