Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling on swim toggle does not work #7054

Closed
mugu2006 opened this issue Sep 7, 2024 · 3 comments
Closed

Cancelling on swim toggle does not work #7054

mugu2006 opened this issue Sep 7, 2024 · 3 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Comments

@mugu2006
Copy link
Contributor

mugu2006 commented Sep 7, 2024

Skript/Server Version

[19:26:06 INFO] [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases

[19:26:06 INFO] [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/

[19:26:06 INFO] [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials

[19:26:06 INFO] [Skript] Server Version: 1.21.1-65-21f125f (MC: 1.21.1)

[19:26:06 INFO] [Skript] Skript Version: 2.9.2 (skriptlang-github)

[19:26:06 INFO] [Skript] Installed Skript Addons:

[19:26:06 INFO] [Skript] - SkBee v3.6.1 (https://github.com/ShaneBeee/SkBee)

[19:26:06 INFO] [Skript] Installed dependencies:

[19:26:06 INFO] [Skript] - WorldGuard v7.0.11-beta1+a801a9d

Bug Description

Title explains it, cancelling the on swim toggle event does nothing, it is detected but not cancelled

Expected Behavior

I'd assume the swimming should have been cancelled and I would remain non-swimming

Steps to Reproduce

    cancel event```
 Use that code, go in water, try to start swimming

### Errors or Screenshots

-

### Other

-

### Agreement

- [X] I have read the guidelines above and affirm I am following them with this report.
@mugu2006
Copy link
Contributor Author

mugu2006 commented Sep 7, 2024

Breh, code I put in steps to reproduce didn't go in, here it is;
on swim toggle:
cancel event
Yes, indents are correct, idk how to put them in on GitHub

@mugu2006
Copy link
Contributor Author

mugu2006 commented Sep 7, 2024

Just learned it can't be cancelled, even though the docs and example state it can.

@Fusezion
Copy link
Contributor

Fusezion commented Sep 7, 2024

It's not the fact it can't be cancelled just more so the fact it doesn't do much of anything this is taken from javadocs for the event

Deprecated.
This does nothing, the server and the client doesn't work correctly when the server try to bypass this. A current workaround exists. If you want to cancel the switch from the ground state to the swimming state you need to disable the sprinting flag for the player after the cancel action.

@Efnilite Efnilite added PR available Issues which have a yet-to-be merged PR resolving it enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Sep 10, 2024
@Efnilite Efnilite added completed The issue has been fully resolved and the change will be in the next Skript update. and removed enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Oct 1, 2024
@Efnilite Efnilite closed this as completed Oct 1, 2024
@Efnilite Efnilite added enhancement Feature request, an issue about something that could be improved, or a PR improving something. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

No branches or pull requests

3 participants