Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EffCancelEvent #7066

Merged
merged 19 commits into from
Oct 1, 2024
Merged

Update EffCancelEvent #7066

merged 19 commits into from
Oct 1, 2024

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Sep 10, 2024 •
edited
Loading

Description

Adds error for trying to cancel the swim toggle event and updates EffCancelEvent:

  • Added test
  • Updated formatting

Target Minecraft Versions: any
Requirements: none
Related Issues: #7054

@cheeezburga cheeezburga reopened this Sep 10, 2024
@cheeezburga
Copy link
Member

Sorry! I misclicked

@Efnilite Efnilite requested a review from Pikachu920 September 10, 2024 16:21
@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Sep 10, 2024
Pikachu920
Pikachu920 requested changes Sep 10, 2024
View reviewed changes
src/test/skript/junit/EffCancelEvent.sk Outdated Show resolved Hide resolved
src/test/skript/junit/EffCancelEvent.sk Outdated Show resolved Hide resolved
@Efnilite Efnilite mentioned this pull request Sep 11, 2024
Merged
@Efnilite
Copy link
Member Author

Efnilite commented Sep 11, 2024 •
edited
Loading

Is awaiting merge of #7067. Thanks sovde!

@Efnilite @sovdeeth
Update src/main/java/ch/njol/skript/effects/EffCancelEvent.java
2436b98 
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
@Efnilite Efnilite requested a review from sovdeeth September 13, 2024 17:23
Pikachu920
Pikachu920 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@Pikachu920 Pikachu920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woooooooooooooooooooo

@Efnilite Efnilite added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Sep 30, 2024
@APickledWalrus APickledWalrus merged commit 92ba72d into SkriptLang:dev/patch Oct 1, 2024
7 checks passed
@Efnilite Efnilite deleted the event-cancel-test branch October 29, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Pikachu920 Pikachu920 Pikachu920 approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Efnilite @cheeezburga @sovdeeth @Pikachu920 @APickledWalrus