Make EffTeleport do teleports asynchronously on Paper #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added shadow plugin to shade and relocate dependencies * Added central variable for paper version * Added PaperLib as a shaded/relocated dependency
ShaneBeee
previously approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Ok after much discussion with JRoy Im approving this... BUT I still want at least @bensku to weigh in on this, and possibly @Pikachu920 and @FranKusmiruk
ShaneBeee
added
2.5
enhancement
change 1.16.3 -> 1.16.4
ShaneBeee
approved these changes
Nov 28, 2020
FranKusmiruk
pushed a commit
that referenced
this pull request
Mar 4, 2021
* Update gradle buildscript * Added shadow plugin to shade and relocate dependencies * Added central variable for paper version * Added PaperLib as a shaded/relocated dependency * Use PaperLib in teleport effect to avoid chunk loads * Fix regression for PlayerRespawnEvent and cleanup code * Update build.gradle change 1.16.3 -> 1.16.4 Co-authored-by: Shane Bee <shanebolenback@me.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR utilizes PaperLib (a first party compatibility layer to make the same code use Paper features on paper and default to spigot spigot servers) to run chunk loads caused by teleport on another thread. This pull request will have no effects on Spigot server and still works as intended
Please see commits and their descriptions for more detail on what this PR changes
Target Minecraft Versions: N/A
Requirements: N/A
Related Issues: #3142, #3355