Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpressionInfo - fix an issue with a previous change that has broken … #3625

Merged
merged 2 commits into from
Dec 10, 2020
Merged

ExpressionInfo - fix an issue with a previous change that has broken … #3625

merged 2 commits into from
Dec 10, 2020

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to fix an issue with the recent API changes to ExpressionInfo that has broken a couple of addons.
Adding back in the original constructor.


Target Minecraft Versions: any
Requirements: none
Related Issues: #3624

…a couple addons

- This provides a constructor that matches the original constructor before the recent changes
@ShaneBeee ShaneBeee added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. 2.5 labels Dec 10, 2020
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂

@ShaneBeee ShaneBeee merged commit 7a6a17c into SkriptLang:dev-2.5 Dec 10, 2020
@ShaneBeee ShaneBeee deleted the fix/ExpressionInfo-changes branch December 10, 2020 13:35
ShaneBeee added a commit that referenced this pull request Dec 11, 2020
…a couple addons (#3625)

- This provides a constructor that matches the original constructor before the recent changes
FranKusmiruk pushed a commit that referenced this pull request Mar 4, 2021
…a couple addons (#3625)

- This provides a constructor that matches the original constructor before the recent changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants