AABB - fix an issue with blocks in WG regions also looping blocks 1 outside the region #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utside the region - In a previous fix to AABB i did not update the other constructor
ShaneBeee
added
2.5
bug
WeeskyBDW
previously approved these changes
Jan 26, 2021
APickledWalrus
previously approved these changes
Mar 1, 2021
Whimsyturtle
dismissed stale reviews from APickledWalrus and WeeskyBDW
The base branch was changed.
Whimsyturtle
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix an issue with the blocks in region expression, returning blocks 1 outside of the region.
In a previous change to AABB I broke it, and when I fixed it, I didn't fix the constructor that is used by WG.
This fixes that issue... 3rd times a charm.
Target Minecraft Versions: any
Requirements: none
Related Issues: #3707