Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove advanced syntax #3709

Merged
merged 4 commits into from
Mar 21, 2021
Merged

Fix/remove advanced syntax #3709

merged 4 commits into from
Mar 21, 2021

Conversation

TPGamesNL
Copy link
Member

@TPGamesNL TPGamesNL commented Jan 25, 2021 •
edited
Loading

Description

This PR disables the Advanced Syntax feature, as it has caused plenty of confusion, and I don't think it's been useful for anyone.
Also typos.

Command to test:

command /test:
	trigger:
		broadcast "Hello, the %sender%"
		broadcast "Hello, a %sender%"
		broadcast "Hello, %sender%s"

Before fix:

Hello, CONSOLE
Hello, CONSOLE
Hello, CONSOLE

After:

Hello, the CONSOLE
Hello, a CONSOLE
Hello, CONSOLEs

Target Minecraft Versions: any
Requirements: none
Related Issues: #367

WeeskyBDW
WeeskyBDW previously approved these changes Jan 26, 2021
View reviewed changes
@ShaneBeee ShaneBeee changed the base branch from master to dev-2.5 January 30, 2021 06:14
@ShaneBeee ShaneBeee dismissed WeeskyBDW’s stale review January 30, 2021 06:14

The base branch was changed.

ShaneBeee
ShaneBeee previously approved these changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... I don't think anyone will miss this.

@ShaneBeee ShaneBeee added 2.5 bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. labels Jan 30, 2021
APickledWalrus
APickledWalrus previously approved these changes Mar 1, 2021
View reviewed changes
@Whimsyturtle Whimsyturtle changed the base branch from dev-2.5 to master March 21, 2021 00:34
@Whimsyturtle Whimsyturtle dismissed APickledWalrus’s stale review March 21, 2021 00:34

The base branch was changed.

@Whimsyturtle Whimsyturtle merged commit 0d2fd5d into SkriptLang:master Mar 21, 2021
@TPGamesNL TPGamesNL deleted the fix/remove-advanced-syntax branch March 21, 2021 12:12
@TPGamesNL TPGamesNL mentioned this pull request Mar 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Whimsyturtle Whimsyturtle Whimsyturtle approved these changes

@WeeskyBDW WeeskyBDW WeeskyBDW left review comments

@APickledWalrus APickledWalrus APickledWalrus left review comments

@ShaneBeee ShaneBeee ShaneBeee left review comments

Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TPGamesNL @Whimsyturtle @ShaneBeee @APickledWalrus @WeeskyBDW