Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower than to CondCompare #3712

Merged

Conversation

TheDGOfficial
Copy link
Contributor

Description

Adds lower than as an alternative to less than or smaller than in CondCompare.

I was trying to use lower than and confused when it wasn't working (because greater than works.) when I was first started on Skript, so this why I'm making this PR; it just come to my mind and decided to make a PR for it.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

As an alternative to less than/smaller than
WeeskyBDW
WeeskyBDW previously approved these changes Jan 26, 2021
@ShaneBeee ShaneBeee changed the base branch from master to dev-2.5 January 30, 2021 06:20
@ShaneBeee ShaneBeee dismissed WeeskyBDW’s stale review January 30, 2021 06:20

The base branch was changed.

ShaneBeee
ShaneBeee previously approved these changes Jan 30, 2021
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ShaneBeee ShaneBeee added 2.5 enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Jan 30, 2021
APickledWalrus
APickledWalrus previously approved these changes Mar 1, 2021
@Whimsyturtle Whimsyturtle changed the base branch from dev-2.5 to master March 21, 2021 00:22
@Whimsyturtle Whimsyturtle dismissed stale reviews from APickledWalrus and ShaneBeee March 21, 2021 00:22

The base branch was changed.

@Whimsyturtle Whimsyturtle merged commit db19a6a into SkriptLang:master Mar 21, 2021
@TheDGOfficial TheDGOfficial deleted the add-lower-than-to-condcompare branch April 12, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants