Fix quote parsing #3762
Merged
Fix quote parsing #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dev-2.6 branch from master
TPGamesNL
added
the
bug
|
Looks good overall but this will definitely break many scripts which have adapted to the bug so, this should go in a major release. |
FranKusmiruk
previously approved these changes
Feb 20, 2021
FranKusmiruk
approved these changes
May 5, 2021
1 task
bilektugrul
added a commit
to bilektugrul/Skript
that referenced
this pull request
Apr 16, 2022
This reverts commit 842bb58.
bilektugrul
added a commit
to bilektugrul/Skript
that referenced
this pull request
Apr 16, 2022
This reverts commit 842bb58.
bilektugrul
added a commit
to bilektugrul/Skript
that referenced
this pull request
Jul 29, 2022
This reverts commit 842bb58
bilektugrul
added a commit
to projects-gg/projects-Skript
that referenced
this pull request
Dec 22, 2022
This reverts commit 842bb58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows singular double quotes to be used in variables and (expressions within strings), instead of doubled double quotes. Includes a regression test.
Target Minecraft Versions: any
Requirements: none
Related Issues: #590, #2806