Add InventoryType support to EffOpenInventory #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
added
2.5
enhancement
TPGamesNL
changed the title
|
Would it be better to remove the converter, and add this to |
|
Yes, I believe this would be better to be added into the actual EffOpenInventory effect. Also the name of the inventory title can be done that way too. |
Done |
FranKusmiruk
approved these changes
Feb 26, 2021
APickledWalrus
changed the title
APickledWalrus
approved these changes
Feb 28, 2021
Whimsyturtle
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a
InventoryType->Inventoryconverter, to allow the usage of inventory types in effects likeEffOpenInventory.Target Minecraft Versions: any
Requirements: none
Related Issues: #3677