-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make log handler system thread safe #3800
Make log handler system thread safe #3800
Conversation
Any reason why not to use
Should it be fixed on my PR then (or another PR), or this one? |
AFAIK EDIT: nvm, just found out that |
If you want to test the Skript from #3453, use this version of skript-reflect: skript-reflect-2.2.2-dev.jar.zip |
|
This reverts commit 9e2778f
Closing as #3924 has been merged, fixing the same issues |
Description
This change gives each thread its own
HandlerList
, making it so that two log systems on separate threads won't interfere with each other.I see two ways this can break:
A log system started on one thread is stopped on another.
A log system is started on one thread, any relies on log entries from another thread.
RedirectingLogHandler
when the reload command is ran, and stop this log handler when the loading is done.SkriptCommand
class, the log handler is often stopped before the loading is done, causing the error count to be wrong, and the log to be redirected to console, instead of the command executor.Target Minecraft Versions: any
Requirements: none
Related Issues: #3453 #1002