Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnresolvedOfflinePlayer thread exception #3827

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Fix UnresolvedOfflinePlayer thread exception #3827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
271 changes: 0 additions & 271 deletions src/main/java/ch/njol/skript/bukkitutil/UnresolvedOfflinePlayer.java
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/main/java/ch/njol/skript/classes/data/BukkitClasses.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,9 +853,6 @@ public OfflinePlayer parse(final String s, final ParseContext context) {
else if (!s.matches("\\S+") || s.length() > 16)
return null;
return Bukkit.getOfflinePlayer(s);
// TODO return an unresolved player and resolve it on a different thread after the command was parsed, and block the command until it is ready
// FIXME add note to changelog if not fixed in the next update
// return new UnresolvedOfflinePlayer(s);
}
// if (s.matches("\"\\S+\""))
// return Bukkit.getOfflinePlayer(s.substring(1, s.length() - 1));
Expand Down