Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix world difficulty not spawning monsters #3921

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

AyhamAl-Ali
Copy link
Member

Description

Fix world difficulty not spawning monsters sometimes after changing from peaceful to others


Target Minecraft Versions: All
Requirements:
Related Issues: #3834

Fix world difficulty not spawning monsters sometimes after changing from peaceful to others
@TPGamesNL TPGamesNL added 2.5 bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. labels Apr 25, 2021
@TPGamesNL
Copy link
Member

I don't think this is an issue with Skript, but rather something with Spigot/Paper

@AyhamAl-Ali
Copy link
Member Author

I don't think this is an issue with Skript, but rather something with Spigot/Paper

It is not Skript's issue, I had to decompile /difficulty command class command and found out that they used the same method, and after they change the difficulty they set the spawnFlag.

@TPGamesNL
Copy link
Member

It is not Skript's issue, I had to decompile /difficulty command class command and found out that they used the same method, and after they change the difficulty they set the spawnFlag.

Then it should still be fixed in Spigot/Paper instead of Skript, unless they specifically say plugins should do this themselves, but that'd surprise me. I recommend you make a small plugin that calls the difficulty changing method and report it to Spigot/Paper

@AyhamAl-Ali
Copy link
Member Author

It is not Skript's issue, I had to decompile /difficulty command class command and found out that they used the same method, and after they change the difficulty they set the spawnFlag.

Then it should still be fixed in Spigot/Paper instead of Skript, unless they specifically say plugins should do this themselves, but that'd surprise me. I recommend you make a small plugin that calls the difficulty changing method and report it to Spigot/Paper

I agree with you, they should do that in setDifficulty method.
I will report that to their issues tracker however, until then I think we better stick with our hotfix what you say?

@TPGamesNL
Copy link
Member

I agree with you, they should do that in setDifficulty method.
I will report that to their issues tracker however, until then I think we better stick with our hotfix what you say?

I think it'd be better to wait for the change in Paper/Spigot (if Skript development were faster a hotfix would be fine)

@AyhamAl-Ali
Copy link
Member Author

I agree with you, they should do that in setDifficulty method.
I will report that to their issues tracker however, until then I think we better stick with our hotfix what you say?

I think it'd be better to wait for the change in Paper/Spigot (if Skript development were faster a hotfix would be fine)

Fair enough.

@AyhamAl-Ali
Copy link
Member Author

AyhamAl-Ali commented Apr 25, 2021

PaperMC/Paper#5546

EDIT:
Reported to Spigot as well

@FranKusmiruk
Copy link
Member

surprisingly enough, Paper declared this behavior as intended and deferred it to upstream (Spigot), knowing them they will probably leave it like that. We'll just merge workaround and call it a day.

@FranKusmiruk FranKusmiruk merged commit 4f5ac2e into SkriptLang:master Apr 26, 2021
@AyhamAl-Ali AyhamAl-Ali deleted the fix/world-difficulty branch June 29, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants