Fix blocks in chunk returning too much #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
added
bug
FranKusmiruk
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed AABB and classes using it, to not make certain regions extended by 1 block. From some of the constructors in AABB you get the impression upperBound is exclusive (because some constructors add 1 to each vector component), but the implementation indicates is actually inclusive, so these aren't needed. I've also changed the calls to
World#getMaxHeight(), because that always returns the 1 above the highest possibly y coord where a block can be found (e.g. 256 instead of 255).Target Minecraft Versions: any
Requirements: none
Related Issues: none