Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExprTool - merge ExprOffTool into ExprTool #4002

Merged
merged 8 commits into from
Jun 17, 2021
Merged

ExprTool - merge ExprOffTool into ExprTool #4002

merged 8 commits into from
Jun 17, 2021

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to merge together the off tool and tool expressions. A big benefit to this is proper documentation as ExprOffTool had NoDocs


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@ShaneBeee ShaneBeee added enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.6 labels May 14, 2021
Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be okay now as long as all of the other concerns have been addressed
image

@ShaneBeee ShaneBeee merged commit 250a1a1 into SkriptLang:master Jun 17, 2021
@ShaneBeee ShaneBeee deleted the feature/merge-offtool-to-tool branch June 17, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants