Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExprYawPitch - fix issue with not being able to set yaw/pitch of location variables #4064

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to fix an issue where setting the yaw/pitch of a location variable did not work.
Snow suggested merging the two yaw/pitch expressions (location and vector) together

I have copied the vector class into this one. This is a preliminary run at the situation.
If y'all want anything changed, lemme know.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

…tion variables

- merge vector/location yaw expressions together solves this issue
@ShaneBeee ShaneBeee added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. 2.6 labels Jun 8, 2021
Copy link
Member

@Nicofisi Nicofisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general!

src/main/java/ch/njol/skript/expressions/ExprYawPitch.java Outdated Show resolved Hide resolved
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I forgot your seal of approval!

@APickledWalrus APickledWalrus merged commit 9547172 into SkriptLang:master Jun 9, 2021
@TPGamesNL TPGamesNL mentioned this pull request Jul 6, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants