Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new Maven repo #4506

Merged
merged 5 commits into from
Jan 17, 2022

Conversation

TPGamesNL
Copy link
Member

Description

Switches to a new Maven repo for Skript, because JitPack has given us some issues we prefer not having (e.g. Skript 2.6 not being available on there). The repo is https://repo.skriptlang.org/releases, see repo.skriptlang.org. A new workflow is added for releases to automatically publish to the repository (and I changed indentation of the existing workflow), and the repository was added to the build.gradle's publishing section. The README was also changed to this repository.

The new repository will automatically fall back to JitPack's repository (and caches the result) if it doesn't have that version yet. It also has a working version of 2.6 added. All you need to do to switch to the new repository is to replace the JitPack URL with the new repo URL https://repo.skriptlang.org/releases.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TPGamesNL TPGamesNL added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 16, 2022
@Moderocky
Copy link
Member

Would there be a way to confirm that it will deploy successfully from GitHub actions? I think you tested it locally but can't remember if you tried from an action.

@TPGamesNL
Copy link
Member Author

I haven't tried from an action and won't be able to do so without releasing an actual version (or by doing it on another GH repo). And Actions will fail or not depending on the exit code of the command ran, so if the publish command fails, it'll show so in the Actions tab, maybe there will also a button on the release for it, and I know I from experience I get an email when an Actions run fails

@TPGamesNL TPGamesNL merged commit ae8f133 into SkriptLang:master Jan 17, 2022
@TPGamesNL TPGamesNL deleted the enhancement/new-maven-repo branch January 17, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants