-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Add inventory raw slot expression #4593
🚀 Add inventory raw slot expression #4593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned that this is handled as a number whereas the regular slot
supports getting and setting the item - even if Bukkit doesn't handle this as easily you could try and support this for parity with the existing expression to avoid confusing users.
I think the idea of |
There is the Maybe that is more confusing though actually lol |
Should this not be raw index instead of raw slot then? |
I was thinking of adding this to More discussion here |
Not a fan of this addition, raw slot is basically never used. |
It's indeed needed in some places if not many when you open 2 inventories the usual slot number will continue after 63 in the below gui while the raw will begin from 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason we didn't change this to return Slot? I forget
Here is more info about our discussion EDIT: New discussion in skript-dev |
Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>
Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>
I don't believe Skript should have this expression. I'm removing my review request from this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one thing.
Also, @TheLimeGlass, what are your reasons for opposing this feature? Sure, it's not widely used by any means, but it's nice to have when needed. I don't see how it could be harmful to have in any way.
Description
This PR Adds a new expression to get the raw inventory slot number, this is a unique number for each view, it basically consider the current opened inventories (top and bottom) as a 1 inventory that begins from the top left
Target Minecraft Versions: Any
Requirements: None
Related Issues: #4461