⚒️ Fix ExprFormatTime CCE + Support non-literals

[AyhamAl-Ali]

Description

• Fixed CCE
• Supported the use of non-literals as custom format such as broadcast now formatted as {_someVar}
• Changed Class name and Doc name Date instead of Time
• Added new pattern

Before PR (CCE)

on chat:
	set {_test} to "HH:mm"
	broadcast now formatted as {_test}

After PR

---

Target Minecraft Versions: Any
Requirements: None
Related Issues: None

[Pikachu920]

instead of requiring a use of literals here, can we just create the format in get if expr[1] is not a literal?

[AyhamAl-Ali]

instead of requiring a use of literals here, can we just create the format in get if expr[1] is not a literal?

It's only there to give skript errors on init if the pattern is incorrect and an exception was thrown tho in this class it wasn't throwing exceptions as in #4663

I will be doing some tests on this to try if I can make it throw an exception if so will have to use try/catch otherwise I think we can do what you said

EDIT:
I was able to trigger it with the character i
!broadcast now formatted with "i"

[TPGamesNL]

@Pikachu920 The reason it was initially required to be a literal is because that way the format can be checked for errors. If we were to parse it as a format at runtime, we could either error at runtime (which I don't think is great, people don't look at console often), or exit silently (which isn't helpful to the user).
Alternatively, we could check if it's a literal (or simple VariableString) and then error if the format is invalid. What would be the best option here?

[Pikachu920]

@Pikachu920 The reason it was initially required to be a literal is because that way the format can be checked for errors. If we were to parse it as a format at runtime, we could either error at runtime (which I don't think is great, people don't look at console often), or exit silently (which isn't helpful to the user).
Alternatively, we could check if it's a literal (or simple VariableString) and then error if the format is invalid. What would be the best option here?

I think that returning null silently is the best option. It's nice to have the format checking for literals, but I don't think limiting to only literals is necessary.

[AyhamAl-Ali]

I think that returning null silently is the best option. It's nice to have the format checking for literals, but I don't think limiting to only literals is necessary.

Though should we check in init if exprs[1] is literal and simple VariableString then we can check for format exceptions otherwise will leave it to runtime and silent the errors, what do you think?

Also, what about leaving warning at runtime for format errors so that at least if a good skripter checks the console would know what's going on/why it isn't working (tho it might spam their console but that's a user error)

[Pikachu920]

I think that returning null silently is the best option. It's nice to have the format checking for literals, but I don't think limiting to only literals is necessary.

Though should we check in init if exprs[1] is literal and simple VariableString then we can check for format exceptions otherwise will leave it to runtime and silent the errors, what do you think?

Also, what about leaving warning at runtime for format errors so that at least if a good skripter checks the console would know what's going on/why it isn't working (tho it might spam their console but that's a user error)

Totally agree. Check for format exceptions when possible, otherwise silently ignore.