Respawn Anchor Support #4855
Merged
Respawn Anchor Support #4855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
requested changes
Jun 30, 2022
There was a problem hiding this comment.
Amazing PR! Thank you for your contribution :)
First pass (not tested yet), a second one will come after these RCs are done and another reviewer would be appreciated.
Mostly simple formatting stuff.
Also you should add Documentation Annotations for each class see other elements for examples
I didn't suggest changes on duplicated parts so make sure to apply the formatting style on all places.
It would be better to split each element in its own PR for faster reviews and to get them merged probably faster.
Well done 👏
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
TheLimeGlass
requested changes
Jun 30, 2022
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
|
We reviewed at the same time, so there are some duplicates there. Sorry about that. When you resolve the same underlying request, you can mark both as resolved. Thank you for the pull request! |
AyhamAl-Ali
requested changes
Jun 30, 2022
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
TheLimeGlass
approved these changes
Jun 30, 2022
APickledWalrus
requested changes
Jun 30, 2022
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
AyhamAl-Ali
requested changes
Jul 1, 2022
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
AyhamAl-Ali
approved these changes
Jul 2, 2022
APickledWalrus
requested changes
Jul 9, 2022
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
APickledWalrus
requested changes
Sep 22, 2022
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
ghost
requested a review
from
APickledWalrus
requested changes
Nov 24, 2022
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
APickledWalrus
approved these changes
Dec 26, 2022
src/main/java/ch/njol/skript/conditions/CondRespawnLocation.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added respawn anchor elements.
Target Minecraft Versions: 1.16+
Requirements: Minecraft Version 1.16+
Related Issues: #4726