-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pathfinding to be double #4915
Conversation
…kript into feature/pathfinding
Pikachu is missing in action, so taken it on. Just a simple change of int to double. Already approved and merged. Caught this last minute. Maybe Paper changed at one point from int to double, or it was missed. Paper handles negative numbers with an absolute. |
…kript into feature/pathfinding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one little thing
@Examples({ | ||
"make all creepers pathfind towards player", | ||
"make all cows stop pathfinding", | ||
"make event-entity pathfind towards player" | ||
"make event-entity pathfind towards player at speed 1" | ||
}) | ||
@Since("INSERT VERSION") | ||
public class EffPathfind extends Effect { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're editing, the check at L49 is no longer needed since it's 1.13+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a Paper Spigot exclusive effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then that class needs @RequiredPlugins
annotation instead of the description note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - make sure to address Ayham's comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last last thing 😄 for Skript 2.7 we no longer specify 1.13+ since Skript will only work on 1.13+ see comment
This makes sense to be at 1.13+ |
Why? |
2.7 only supports 1.13+ |
Description
Makes the pathfinding a double rather than an integer