Adventure Chat Integration [EXPERIMENT] #4971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was designed to maintain compatibility with Spigot.
Also includes improvements and fixes to current changes
This results in much faster execution times comparable to the current system. However, it also means that Spigot is no longer supported, and versions below 1.17 won't work. (Paper 1.17+ only now)
This reverts commit ffe1f1a.
This reverts commit a6566f3.
APickledWalrus
added
feature
The goal here isn't possible of course, as we relocate the dependency.
TheLimeGlass
reviewed
Aug 1, 2022
|
|
||
| # Other API | ||
|
|
||
| component: component¦s @a |
There was a problem hiding this comment.
I think we should add chat component as another aliases
kiip1
approved these changes
Jan 5, 2023
Comment on lines
+75
to
+77
| boolean format; | ||
| // Whether all formatting should be removed | ||
| boolean unformatted; |
There was a problem hiding this comment.
Could replace with a TriState.
Comment on lines
+31
to
+54
| CODE_MAP.put('0', "black"); | ||
| CODE_MAP.put('1', "dark_blue"); | ||
| CODE_MAP.put('2', "dark_green"); | ||
| CODE_MAP.put('3', "dark_aqua"); | ||
| CODE_MAP.put('4', "dark_red"); | ||
| CODE_MAP.put('5', "dark_purple"); | ||
| CODE_MAP.put('6', "gold"); | ||
| CODE_MAP.put('7', "gray"); | ||
| CODE_MAP.put('8', "dark_gray"); | ||
| CODE_MAP.put('9', "blue"); | ||
| CODE_MAP.put('a', "green"); | ||
| CODE_MAP.put('b', "aqua"); | ||
| CODE_MAP.put('c', "red"); | ||
| CODE_MAP.put('d', "light_purple"); | ||
| CODE_MAP.put('e', "yellow"); | ||
| CODE_MAP.put('f', "white"); | ||
|
|
||
| CODE_MAP.put('o', "italic"); | ||
| CODE_MAP.put('l', "bold"); | ||
| CODE_MAP.put('m', "strikethrough"); | ||
| CODE_MAP.put('n', "underlined"); | ||
| CODE_MAP.put('k', "obfuscated"); | ||
|
|
||
| CODE_MAP.put('r', "reset"); |
There was a problem hiding this comment.
Pull from org.bukkit.ChatColor instead, except for underlined and obfuscated. (For those the Enum name doesn't match this string one).
Comment on lines
+342
to
+347
| public static Audience audienceFrom(CommandSender... senders) { | ||
| List<Audience> bukkitAudiences = new ArrayList<>(); | ||
| for (CommandSender sender : senders) | ||
| bukkitAudiences.add(getAdventure().sender(sender)); | ||
| return Audience.audience(bukkitAudiences); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public static Audience audienceFrom(CommandSender... senders) { | |
| List<Audience> bukkitAudiences = new ArrayList<>(); | |
| for (CommandSender sender : senders) | |
| bukkitAudiences.add(getAdventure().sender(sender)); | |
| return Audience.audience(bukkitAudiences); | |
| } | |
| public static Audience audienceFrom(CommandSender... senders) { | |
| return audienceFrom(ImmutableList.copyOf(senders)); | |
| } |
Comment on lines
+331
to
+334
| List<Audience> bukkitAudiences = new ArrayList<>(); | ||
| for (CommandSender sender : senders) | ||
| bukkitAudiences.add(getAdventure().sender(sender)); | ||
| return Audience.audience(bukkitAudiences); |
There was a problem hiding this comment.
Could use Stream api but this is fine.
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class ComponentHandler { |
There was a problem hiding this comment.
Suggested change
| public class ComponentHandler { | |
| @ApiStatus.Internal | |
| public final class ComponentHandler { | |
| private ComponentHandler() {} |
1 task
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0 to
3f08853
Compare
|
Closing as I do not feel these changes are well integrated. I'll re-examine how we can better integrate these libraries with a fresh start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for tracking my experiment. A lot of work still needs done. Comments/tests welcome though!
Currently has some breaking changes (in that some color tags parse differently).
This PR depends on the Module API. If we don't end up doing that, I can make changes accordingly.
Target Minecraft Versions: Any
Requirements: N/A
Related Issues: