Arithmetic Rework

[UnderscoreTud]

Description

This PR reworks the arithmetic system and expression, it allows addons (and skript) to very easily register their own custom arithmetic type; making the arithmetic expression more versatile. How you register an arithmetic is quite similar to how changers register, examples from the current registered arithmetics here, and they work similarly. An operator is given to an arithmetic then that arithmetic can return an array of classes to determine what can be used as the second value of the operation (same as Changers).

Note:
This is change may break addons that use the current arithmetic system, I tried to make it backwards compatible but there are no guarantees that it won't break them

Some examples of what can be done using this new system:

The current registered arithmetic types are:

• Numbers (obviously)
• Vectors (closes Add Vector-Number Arithmetic back #5159)
• Timespans
• Date
• Money

---

Target Minecraft Versions: any
Requirements: none
Related Issues: #4253

[APickledWalrus]

Overall, looks really solid! Great work.

There will probably be a few other things, but I'm going to ask around for some input first + see how it looks after current requested changes are made :)

[Fusezion]

So this just crossed my mind, order of operations are still done in order with this system right so 1 + 3 * 2 returns 7 not 8

[UnderscoreTud]

Yes, they are still in order

[APickledWalrus]

Looking really good now!

[APickledWalrus]

I'm thinking this is okay now - another review or two is definitely necessary

Excellent work!

Also, I think we should try to add some tests if possible (not sure what currently exists)

[Moderocky]

This should have comprehensive (if not exhaustive) tests written. :)

[UnderscoreTud]

converted to draft while I fix some bugs with the new system