ExprYawPitch: support for entities, better description #5298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 30, 2022 16:50
…ar, made code consistent
AyhamAl-Ali
added
the
enhancement
Co-authored-by: Ayham Al Ali <alali_ayham@yahoo.com>
Co-authored-by: Ayham Al Ali <alali_ayham@yahoo.com>
Co-authored-by: Ayham Al Ali <alali_ayham@yahoo.com>
TheLimeGlass
requested changes
Feb 4, 2023
| "set pitch of player to 90 # Makes the player look upwards, Paper 1.19+ only", | ||
| "add 180 to yaw of target of player # Makes the target look behind him" | ||
| }) | ||
| @Since("2.0, 2.2-dev28 (vector yaw/pitch), INSERT VERSION (changers)") | ||
| public class ExprYawPitch extends SimplePropertyExpression<Object, Number> { |
There was a problem hiding this comment.
Should return Float rather than Number.
Moderocky
force-pushed
the
master
branch
2 times, most recently
from
bd134d0 to
3f08853
Compare
sovdeeth
approved these changes
Mar 19, 2024
Moderocky
approved these changes
Apr 12, 2024
APickledWalrus
approved these changes
May 31, 2024
sovdeeth
added
the
feature-ready
TheLimeGlass
previously requested changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made the code consistent. Sometimes it would use the Bukkit system, and sometimes the Skript system. Now it only uses Skript's system.A quick overview of the differences between Skript's yaw and pitch system:A yaw of 0 represents the positive x direction. Rotating by a positive number will rotate the yaw counter-clockwise.A pitch of 90 represents the positive y direction. Adding a positive number to the pitch will rotate upwards.Edit (@sovdeeth): I've reverted the yaw/pitch changes to ensure that the yaw/pitch will be the same before and after this PR. This means yaw is the same as Minecraft's, but always positive ( [0, 360) instead of [-180, 180) ) and that pitch is exactly the same as Minecraft.
Target Minecraft Versions: any
Requirements: N/A
Related Issues: N/A