🛠 Fix Duplicated Spaces in StructCommand #5416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
added
the
bug
TPGamesNL
previously requested changes
Feb 1, 2023
There was a problem hiding this comment.
I think the regex pattern change is good (do separate the fields onto multiple lines :)
I think we shouldn't assume that the matcher (line 186) returns true, cause they're different parsers. I think it'd be better to return false when there's no match (maybe error too)
Moderocky
reviewed
Feb 2, 2023
…e' into fix/dup-spaces-cmd-structure
Moderocky
approved these changes
Feb 14, 2023
TheLimeGlass
suggested changes
Feb 14, 2023
UnderscoreTud
approved these changes
Feb 14, 2023
TheLimeGlass
approved these changes
Mar 8, 2023
AyhamAl-Ali
added a commit
to AyhamAl-Ali/Skript
that referenced
this pull request
Aug 21, 2023
AyhamAl-Ali
added a commit
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StructCommand Regex did not support duplicated spaces between
commandand/which causescommand /testto throw an ISE (IllegalStateException)This PR fixes it by supporting multiple spaces
Target Minecraft Versions:
Requirements:
Related Issues: