Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Shearing Related Elements #5571

Merged
merged 15 commits into from
Sep 18, 2023
Merged

Enhance Shearing Related Elements #5571

merged 15 commits into from
Sep 18, 2023

Conversation

NotSoDelayed
Copy link
Contributor

@NotSoDelayed NotSoDelayed commented Mar 30, 2023 •
edited
Loading

Description

This PR enhances shearing related elements of Skript, such as:

  • Support of Shearable interface into EffShear.class
  • New condition: CondIsSheared (%livingentity% is (sheared|shorn))

Notice: Breaking Change

EffShear.class now defaults to usage of Shearable interface methods if available on the server, or else fallbacks to 'shear state' methods. Usage of former will manipulate the actual shearing as if it is done by a player, as stated in the method description.

Target Minecraft Versions: 1.13+
Requirements: Paper 1.19.4 (Shearable interface support)
Related Issues: #5561's comment

@AyhamAl-Ali AyhamAl-Ali added enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature Pull request adding a new feature. labels Mar 30, 2023
@TheLimeGlass TheLimeGlass requested a review from AyhamAl-Ali April 9, 2023 00:55
NotSoDelayed and others added 3 commits April 10, 2023 11:33
@NotSoDelayed @TheLimeGlass
Requested change
d2a9779 
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
@NotSoDelayed
Camel case static final field
9548ea2
@NotSoDelayed
Merge remote-tracking branch 'origin/enhance/effshear' into enhance/e…
0b295d0 
…ffshear
@NotSoDelayed NotSoDelayed requested a review from Moderocky April 29, 2023 14:11
@TheLimeGlass TheLimeGlass removed their request for review May 2, 2023 20:55
Moderocky
Moderocky approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. We might want to look at supporting shearing mooshrooms -> cows one day but I don't think it's a priority.

@Moderocky Moderocky force-pushed the master branch 2 times, most recently from bd134d0 to 3f08853 Compare September 16, 2023 16:59
@Moderocky Moderocky changed the base branch from master to dev/feature September 18, 2023 10:26
@Moderocky Moderocky added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Sep 18, 2023
@Moderocky Moderocky merged commit 38bfa0a into SkriptLang:dev/feature Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

@Moderocky Moderocky Moderocky approved these changes

@AyhamAl-Ali AyhamAl-Ali Awaiting requested review from AyhamAl-Ali

@UnderscoreTud UnderscoreTud Awaiting requested review from UnderscoreTud

@APickledWalrus APickledWalrus Awaiting requested review from APickledWalrus

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NotSoDelayed @Moderocky @TheLimeGlass @AyhamAl-Ali