Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Add inventory close reasons #5680

Merged
merged 12 commits into from
Aug 25, 2023
Merged

🚀 Add inventory close reasons #5680

merged 12 commits into from
Aug 25, 2023

Conversation

AyhamAl-Ali
Copy link
Member

Description

Adds inventory close reasons enumclassinfo and expression

Target Minecraft Versions: Any
Requirements: None
Related Issues: None

@AyhamAl-Ali AyhamAl-Ali added the feature Pull request adding a new feature. label May 5, 2023
AyhamAl-Ali and others added 3 commits May 6, 2023 08:38
@AyhamAl-Ali @TheLimeGlass
Apply suggestions from code review
2f3bdfb 
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
@AyhamAl-Ali
Add classExists check
aa412a1
@AyhamAl-Ali
Use EventValueExpression
ba95495
@AyhamAl-Ali AyhamAl-Ali requested a review from TheLimeGlass May 6, 2023 06:20
@AyhamAl-Ali AyhamAl-Ali requested a review from TheLimeGlass May 6, 2023 18:57
TheLimeGlass
TheLimeGlass suggested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@TheLimeGlass TheLimeGlass left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're checking if the class exists, is it not 1.13+? Or is it a Paper enum? Needs the RequiredPlugins annotation for documentation, and method for the classinfo.

@AyhamAl-Ali AyhamAl-Ali requested a review from TheLimeGlass June 6, 2023 19:02
sovdeeth
sovdeeth requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one thing

src/main/resources/lang/default.lang Outdated Show resolved Hide resolved
@AyhamAl-Ali AyhamAl-Ali requested a review from sovdeeth August 22, 2023 06:54
@AyhamAl-Ali AyhamAl-Ali merged commit e6a94ed into SkriptLang:master Aug 25, 2023
Moderocky pushed a commit to Moderocky/Skript that referenced this pull request Sep 16, 2023
@AyhamAl-Ali @Moderocky
🚀 Add inventory close reasons (SkriptLang#5680)
39c351c
NotSoDelayed pushed a commit to NotSoDelayed/Skript that referenced this pull request Oct 30, 2023
@AyhamAl-Ali @NotSoDelayed
🚀 Add inventory close reasons (SkriptLang#5680)
1c6a5c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnderscoreTud UnderscoreTud UnderscoreTud approved these changes

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

@APickledWalrus APickledWalrus Awaiting requested review from APickledWalrus

Assignees
No one assigned
Labels
feature Pull request adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AyhamAl-Ali @sovdeeth @Moderocky @TheLimeGlass @UnderscoreTud