Address Variable Loading Changes #5892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is already in a delayed task.
UnderscoreTud
approved these changes
Aug 8, 2023
Moderocky
approved these changes
Aug 8, 2023
AyhamAl-Ali
pushed a commit
to AyhamAl-Ali/Skript
that referenced
this pull request
Aug 9, 2023
Remove delayed task call around variable loading It is already in a delayed task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR address the issue of variables loading after script loading occurs (meaning events like
on script loadhave already triggered). This change was made in #4873, where the intent may have been to allow addons to provide users the ability to register their own variable storage implementations within scripts. Additional changes will need to be made and tested for something like that to be feasible. It is important to note that this PR will not affect the ability for addons to register their own storage implementations. This code is still executed within a delayed task (it is just executed before scripts load now).Target Minecraft Versions: any
Requirements: none
Related Issues: