Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Timings for 1.19.4+ #5917

Merged
merged 3 commits into from
Aug 19, 2023
Merged

Disable Timings for 1.19.4+ #5917

merged 3 commits into from
Aug 19, 2023

Conversation

sovdeeth
Copy link
Member

@sovdeeth sovdeeth commented Aug 17, 2023 •
edited
Loading

Description

Prevents Skript from enabling Timings support for Paper versions 1.19.4 or greater.

Target Minecraft Versions:
Requirements:
Related Issues: #5726

@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.7 Targeting a 2.7.X version release labels Aug 17, 2023
@sovdeeth sovdeeth requested a review from TheLimeGlass August 17, 2023 19:07
TheLimeGlass
TheLimeGlass approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@TheLimeGlass TheLimeGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe a suggestion issue should be created to add further support into Spark (Spark is what Paper is transitioning to)

@sovdeeth
Copy link
Member Author

I believe a suggestion issue should be created to add further support into Spark (Spark is what Paper is transitioning to)

We may want to wait for lucko/spark#242 to have, like, any progress made. As of right now, I don't believe there is any api available to add additional metadata like line numbers/scripts to bring Spark timings to parity with what we had with Timings.

@TheLimeGlass
Copy link
Contributor

I believe a suggestion issue should be created to add further support into Spark (Spark is what Paper is transitioning to)

We may want to wait for lucko/spark#242 to have, like, any progress made. As of right now, I don't believe there is any api available to add additional metadata like line numbers/scripts to bring Spark timings to parity with what we had with Timings.

That's why an issue suggestion should be made as a reminder.

@TheLimeGlass TheLimeGlass merged commit 7f38b86 into SkriptLang:master Aug 19, 2023
sovdeeth added a commit to sovdeeth/Skript that referenced this pull request Aug 20, 2023
@sovdeeth
Disable Timings for 1.19.4+ (SkriptLang#5917)
8e52a0b 
* Disable Timings for 1.19.4+

* Update SkriptConfig.java

(cherry picked from commit 7f38b86)
@sovdeeth sovdeeth mentioned this pull request Aug 20, 2023
Merged
Moderocky pushed a commit that referenced this pull request Aug 20, 2023
@sovdeeth
[2.7.0 target] Disable Timings for 1.19.4+ 5917 (#5926)
d6cabe1 
Disable Timings for 1.19.4+ (#5917)

* Disable Timings for 1.19.4+

* Update SkriptConfig.java

(cherry picked from commit 7f38b86)
@sovdeeth sovdeeth deleted the disable-timings branch September 26, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@AyhamAl-Ali AyhamAl-Ali AyhamAl-Ali approved these changes

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

@Moderocky Moderocky Moderocky approved these changes

Assignees
No one assigned
Labels
2.7 Targeting a 2.7.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sovdeeth @TheLimeGlass @Moderocky @AyhamAl-Ali @APickledWalrus